Properly handle shmget() ENOMEM error conditions on Windows #9748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
reviewed
Oct 14, 2022
|
This looks like a really nice fix. Can I ask if there is any desire to get this merged? Looking into newer PHP build failures on Windows, it does seem that they could be influenced by seemingly small bugs like this fixes. |
|
I'm unsure why no CI is running for this ? anyone ? It looks correct and perfectly reasonable to merge, but I'm reluctant without running tests. @cmb69 if you're around could you get this to run CI ? |
We need to properly handle `MapViewOfFileEx()` failures; otherwise strange error messages might be reported in the following. E.g. bug72858.phpt is likely to fail on 32bit Windows with "Warning: shm_attach(): Failed for key 0x64: File exists".
cmb69
force-pushed
the
cmb/shmget-enomem
branch
from
d0f6370 to
b9a14f6
Compare
|
I have rebased onto current master, and now CI is running. Still not sure whether CI is really helpful here (as far as I know, we have only few tests regarding SHM on Windows). And I can barely remember what this PR is about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to properly handle
MapViewOfFileEx()failures; otherwise strange error messages might be reported in the following. E.g. bug72858.phpt is likely to fail on 32bit Windows with "Warning: shm_attach(): Failed for key 0x64: File exists".Note that this issue also affects older PHP versions, but the chance of
MapViewOfFileEx()failing is very small there, because we only tried to map an info segment there, instead of trying to map the whole segment now, due to #8648.